Conversation
added 2 commits
September 6, 2022 12:37
Contributor
Author
|
While we are waiting on the progress on #1338 from ink repo. The section can just contain |
SkymanOne
requested review from
HCastano,
ascjones and
cmichi
as code owners
HCastano
reviewed
Sep 8, 2022
Contributor
HCastano
left a comment
HCastano
left a comment
There was a problem hiding this comment.
Will be a good addition to the docs, thanks!
Can you wrap lines to 90ish characters? Makes it easier to
read the source files
cmichi
reviewed
Sep 14, 2022
Collaborator
cmichi
left a comment
cmichi
left a comment
There was a problem hiding this comment.
Thank you! Got some nits.
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> Co-authored-by: Michael Müller <mich@elmueller.net>
cmichi
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #82